This repository was archived by the owner on Dec 15, 2022. It is now read-only.
grammar: Do not randomly sprinkle recursive includes#15
Merged
Conversation
Author
|
If somebody who actually writes Clojure could verify that the highlighted output still makes sense, that'd be nice and dandy. Here's the grammar in Lightshow: example |
Contributor
|
I'm more than happy to merge this in and publish, but I'm not somebody who actually writes Clojure. |
kevinsawicki
added a commit
that referenced
this pull request
Feb 23, 2015
grammar: Do not randomly sprinkle recursive includes
Author
|
I guess the fastest way is going to be to deploy this in production and see if Clojure users complain of any issues. ;) |
Slowki
pushed a commit
to Slowki/hy.tmLanguage
that referenced
this pull request
Sep 14, 2018
grammar: Do not randomly sprinkle recursive includes
Slowki
pushed a commit
to Slowki/hy.tmLanguage
that referenced
this pull request
Sep 14, 2018
grammar: Do not randomly sprinkle recursive includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that #13 introduce some changes to the grammar that caused unbounded (and unnecessary) meta recursion on most rules, greatly increasing the verbosity of the output HTML. Since all
includesubrules in the patterns dictionary already had$selfincluded, this just added a rather silly loop to the grammar.This fixes the noisy HTML output that was reported in https://twitter.com/swannodette/status/568516306648977409
cc @aroben