Namespaces, definitions, dynamic variables, metadata and #13
Conversation
…guish the first symbol in a sexp.
There was a problem hiding this comment.
I think the \n here isn't needed since \s matches \n characters
|
Would you mind rebasing/merge in master? I just added Travis and a simple spec that verifies the grammar parses. |
|
Done and done. I also added an extra commit to fix the scopes for the beginnings and ends of maps and sets. |
There was a problem hiding this comment.
I don't think you need to have these all escaped since they are already in a character class. The only ones for sure would be things like \w and - to differentiate it from a range.
There was a problem hiding this comment.
Probably not. I copied it from somewhere else in the grammar; maybe the #keyword definition. Works well enough 😄
There was a problem hiding this comment.
Cool, lets just leave it then
|
Thanks for these really nice improvements |
Namespaces, definitions, dynamic variables, metadata and
|
No problem 😄 |
Namespaces, definitions, dynamic variables, metadata and
Namespaces, definitions, dynamic variables, metadata and
I'm writing a theme for Clojure, and I was missing some stuff, such as:
namespace/variables*dynamic-variables*def/defn/...^:metadataSo I wrote this fork. The end result looks something like this (using my personal theme; the coloring is a work in progress 😄 ):
For comparison, here's how the same code looks without these modifications: