close
The Wayback Machine - https://web.archive.org/web/20201008212941/https://github.com/TheAlgorithms/Python/pull/2973
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default args and type hints for Project Euler problem 7 #2973

Merged
merged 1 commit into from Oct 8, 2020
Merged

Add default args and type hints for Project Euler problem 7 #2973

merged 1 commit into from Oct 8, 2020
+49 −32

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 7, 2020

Continuing #2786

  • Add default argument values
  • Add type hints
  • Change one letter variable names to a more descriptive one
  • Add doctest for solution()

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
@dhruvmanila
Add default args and type hints for problem 7
Verified
This commit was signed with a verified signature.
Image dhruvmanila Dhruv
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
26a797d 
- Add default argument values
- Add type hints
- Change one letter variable names to a more descriptive one
- Add doctest for `solution()`
@dhruvmanila dhruvmanila requested review from Kush1101 and shellhub Oct 7, 2020
@dhruvmanila dhruvmanila mentioned this pull request Oct 8, 2020
Open
@cclauss
cclauss approved these changes Oct 8, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM
@cclauss cclauss merged commit 719c556 into TheAlgorithms:master Oct 8, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@dhruvmanila dhruvmanila deleted the dhruvmanila:patch-problem-7 branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@shellhub shellhub

@Kush1101 Kush1101

Assignees
No one assigned
Labels
Need Reviews
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dhruvmanila @cclauss
You can’t perform that action at this time.