Remove port from host configuration in installer#484
Merged
Conversation
mttdffy
approved these changes
Aug 11, 2020
Contributor
mttdffy
left a comment
There was a problem hiding this comment.
This will also cause url generation for redirects and such while in dev to not work properly.. idk how we'd resolve both issues...
tubbo
suggested changes
Aug 11, 2020
Contributor
tubbo
left a comment
There was a problem hiding this comment.
yeah I think we need to do some more solid testing here...or else we should just configure site-builder to not consider the port when looking at Workarea.config.host.
Ports aren't part of hosts, this causes problems when the value is used like a true host. This PR also fixes mailer links with missing ports as a result of this change.
c7a1323 to
94b47e6
Compare
Contributor
Author
|
@mttdffy I fixed the mailers, what redirects are you talking about? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports aren't part of hosts, this causes problems when the value is used like a true host.