feat: add createReport and .vitest report directory convention#9993
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Apr 22, 2026
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
commented
Mar 27, 2026
AriPerkkio
commented
Mar 27, 2026
sheremet-va
reviewed
Mar 27, 2026
Collaborator
|
Looks good to me. For the follow-up, would we also add |
This comment was marked as spam.
This comment was marked as spam.
4 tasks
.vitest results directory conventioncreateResultsWriter and .vitest results directory convention
createResultsWriter and .vitest results directory conventioncreateResultWriter and .vitest results directory convention
createResultWriter and .vitest results directory conventioncreateResultWriter and .vitest results directory convention
AriPerkkio
commented
Apr 10, 2026
54c6d60 to
06187af
Compare
06187af to
bafc69b
Compare
hi-ogawa
previously approved these changes
Apr 11, 2026
b5e8c66 to
22a357e
Compare
hi-ogawa
previously approved these changes
Apr 13, 2026
sheremet-va
reviewed
Apr 13, 2026
sheremet-va
requested changes
Apr 13, 2026
Member
|
Maybe adding readdir would also be helpful |
createResultWriter and .vitest results directory conventioncreateReport and .vitest report directory convention
hi-ogawa
previously approved these changes
Apr 14, 2026
AriPerkkio
commented
Apr 14, 2026
AriPerkkio
commented
Apr 17, 2026
Member
Author
AriPerkkio
left a comment
There was a problem hiding this comment.
Team meeting notes:
- Lets' mark this as experimental and release in next patch too. Stabilize in 5.0.0
68b12bf to
38f9b1c
Compare
Member
|
Oops, I forgot about this one for 4.1.5 👀 We can either release a 4.1.6 or keep it in 5.0.0. |
sheremet-va
previously approved these changes
Apr 21, 2026
| function delete(filename: string): Promise<void> | ||
| ``` | ||
|
|
||
| Delete a file from the report directory for this scope. |
Member
There was a problem hiding this comment.
Doesn't it also deletes a folder?
AriPerkkio
commented
Apr 22, 2026
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
sheremet-va
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9952
Once merged, I'll create follow-up issue for using
.vitestin Vitest's built-in reporters (at least html?) and for other artifacts. Changing default values will be breaking change.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.