Support for akka 2.2.1#169
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Extending things in the akka package? really needed?
Contributor
Author
There was a problem hiding this comment.
Yea. Serialization.currentTransportInformation is private to the akka package. On the second thought this probably means that it should not be accessed from outside and ActorRef should be serialized in some other way. I will investigate that.
Contributor
Author
|
Found a more clean solution. It seems that akka team provided ActorRef serializer, which is now beeing used in the fix. |
Contributor
Author
|
Yea... Forgot to actually write to Output. Fixed that. |
Contributor
|
Given that sort of typo had a clean build, maybe some tests that things RT through the kryo properly? |
Contributor
Author
|
Added a test which puts ActorRef through serialization and deserialization. |
Contributor
|
Looks good! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
are you guys thinking about Akka 2.2.1? This is a quick patch which makes chill compile against akka 2.2.1, but not akka 2.1.4.
If you are not planning to upgrade soon, maybe I should think of backwards compatible solution.