fix(message-view): Respect animation setting when displaying message body#10796
Conversation
…body **Description:** Disable fade-in animation when opening messages if the user has disabled animations in Thunderbird's own app settings. The fix was written with AI, but testing, code review and commit messages were done manually. Fixes thunderbird#1903 **Testing:** 1. Go to Settings > General > Display > Use gaudy... and disable it 2. Open any email message 3. Verify the message content appears without fade-in In most cases the message view still loads in steps and feels jumpy, but without any animation.
|
Missing report label. Set exactly one of: |
|
|
|
Missing report label. Set exactly one of: |
Convert the "Use gaudy visual effects" boolean checkbox to a tri-state option (On/Off/Use system default) that defaults to following Android's system animation accessibility setting. Similar to ThemeManager, introduce a new AnimationManager and funnel all access to this option through there. I'm on the fence as to whether that isn't too much overkill, IMO it would make sense to merge them both into one "settings manager". Right now there is only one place where the setting is being read, in ViewSwitcher. However, there are many other places where the setting is supposed to be respected but isn't (sidebar, messagetopview thunderbird#10796) so I figured it's better to centralize the resolution outside of ViewSwitcher.
|
Missing report label. Set exactly one of: |
rafaeltonholo
left a comment
There was a problem hiding this comment.
LGTM! Thank you for contributing to our project!
|
Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 20. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org |
Description:
Disable fade-in animation when opening messages if the user has disabled animations in Thunderbird's own app settings.
The fix was written with AI, but testing, code review and commit messages were done manually.
Fixes #1903
Testing:
In most cases the message view still loads in steps and feels jumpy, but without any animation.