Manually resolve broken net-smtp dependency#2761
Merged
Merged
Conversation
c1ce915 to
6af0389
Compare
Member
|
Ah, nice. Yeah, I'd been seeing the Annoyingly, I can't reproduce the Appraisal issue: |
On Ruby 3.3, it seems like a transitive dependency which wasn't needed now is. So we add it.
c4a204d to
e968a5e
Compare
Member
|
I broke out the logger problem into #2765. I'm not sure about the Appraisal problem. I've seen a few weird issues now and again, but it's very tricky to get to the bottom of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #2440, I saw strange CI failures. Looking into it, they don't appear to be related to the PR, but I can't really explain them.
One is related to Ruby 3.3. For some reason, a transitive dependency that wasn't necessary before is needed now? And running
bundle update net-smtpsimply added it? Beats me.The other was an issue with Rails 6.x. Looking it up, I found this discussion at StackOverflow. Requiring
loggerat the right place appears to fix it...?Additionally, Appraisal seems to be doing something wrong in my computer (tested in macOS) and as a result I can't run some appraisals. See:
Any ideas of what that could be?