Ensure danger buttons have red hover state#2742
Merged
Merged
Conversation
Member
lol Could you rebase this when you get a chance? Otherwise it looks good! |
074cb1a converted links that submit forms to buttons. To keep these now-buttons looking like links it uses the `link` class. CSS looks for buttons that are `not(.link)` to continue to style them appropriately. However any `.button--danger` buttons did not get all the style overrides. In particular, `:hover` and `:disabled:hover` states fell back to the normal button background colors (blue). This fixes those buttons to have the appropriate red hover states. In addition, `.link--danger` elements also had a blue hover state. I'm not sure when this was broken, or if it was always supposed to be like that. Either way, I changed it so they now also appear slightly darker when hovered to match the buttons.
55b04ad to
19c3705
Compare
Contributor
Author
|
Look, I just love removing 3.3k lines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
074cb1a converted links that submit forms to buttons. To keep these now-buttons looking like links it uses the
linkclass. CSS looks for buttons that arenot(.link)to continue to style them appropriately.However any
.button--dangerbuttons did not get all the style overrides. In particular,:hoverand:disabled:hoverstates fell back to the normal button background colors (blue).This fixes those buttons to have the appropriate red hover states.
In addition,
.link--dangerelements also had a blue hover state. I'm not sure when this was broken, or if it was always supposed to be like that. Either way, I changed it so they now also appear slightly darker when hovered to match the buttons.