Updated Views::IndexGenerator to copy all partials#2452
Conversation
|
I'm not sure if we do actually want to do this — are you finding you do override stuff like pagination, or the headers? The code here hasn't changed much in years. One other option would be to add a new generator for overriding the specifics, or we could also just do nothing and let users figure it out! |
|
@nickcharlton These templates are not generated by any generator. Shouldn't we enable them to be generated by the generator as a guide for users who want to customize the templates?
I'm prepared to create a new generator and submit a pull request. In that case, what do you think would be an appropriate name for the generator? |
|
Initially I wasn't keen into incorporating these partials on the generator, but I'm less sure now. I think a user wanting to customise the index views will want them, so it makes sense to provide them. |
|
Yeah, I was thinking the same, but I think it's worthwile having now. @goosys, would you like to revisit this? I think it needs a rebase and that's probably it. |
cf188fa to
4b7b7ed
Compare
|
Thank you for checking. I rebased. |
I believe this is an oversight from when the templates were split in a previous version.
Please review.