Update selenium-webdriver and remove webdrivers#2419
Conversation
|
CI is failing on this PR because |
selenium-webdriver and remove webdriversselenium-webdriver and remove webdrivers; drop support for Ruby 2.7
|
@nickcharlton wasn't sure about dropping support for Ruby 2.7 recently, so pinging him here 🙂 (I'm ok with dropping it). |
|
I don't think we should drop it yet, even though it's EOL. I've not been able to keep up with the recent Selenium changes, is stopping running any tests against it breaking that completely? Is there something else we can pin for older Ruby versions? |
|
I thought that webdrivers had the ability to download the correct (or in this case, pinned) version automatically? I guess this is not happening here. Could that be something that can be fixed? Am I mixing this up with something else? |
|
|
|
Where are we on fixing Selenium/Webdrivers/etc? What should we do here? The initial change seems to have settled down now and everything adjusted. |
|
I was just fixing my local setup yet again, and got it working with pretty much the same changes as in this PR. @nickcharlton - Any thoughts on when it would be ok to drop Ruby 2.7? |
This was originally introduced in #2419, but is worth breaking out.
|
I just opened #2469, which is the Ruby 2.7 removal. I figured that since we need that to do this, we should go about 2.7 now. I cherry-picked @thoughtbot-summer's commit, so the change doesn't get lost when we built the CHANGELOG. |
This was originally introduced in #2419, but is worth breaking out. Co-authored-by: Summer ☀️ <summer@thoughtbot.com>
…so that we can use Chromium 115+, per `webdrivers`' recommendation <https://github.com/titusfortner/webdrivers/tree/v5.3.1#update-future-of-this-project>
a2487c8 to
64473e9
Compare
selenium-webdriver and remove webdrivers; drop support for Ruby 2.7selenium-webdriver and remove webdrivers
I was unable to run tests locally, because I have Chromium v116 installed, but the tests lock
chromedriverto v114. Perwebdrivers' recommendation, this change updatesselenium-webdriverand removeswebdriver, allowing us to remove that version constraint.