close
Skip to content

Update selenium-webdriver and remove webdrivers#2419

Merged
nickcharlton merged 1 commit into
mainfrom
selenium-chromium-greater-than-114
Dec 12, 2023
Merged

Update selenium-webdriver and remove webdrivers#2419
nickcharlton merged 1 commit into
mainfrom
selenium-chromium-greater-than-114

Conversation

@thoughtbot-summer
Copy link
Copy Markdown
Contributor

I was unable to run tests locally, because I have Chromium v116 installed, but the tests lock chromedriver to v114. Per webdrivers' recommendation, this change updates selenium-webdriver and removes webdriver, allowing us to remove that version constraint.

@thoughtbot-summer
Copy link
Copy Markdown
Contributor Author

CI is failing on this PR because selenium-webdriver dropped support for Ruby 2.7 (because Ruby 2.7 is EOL). Should we also drop support for it? This would only affect CI for now, since we don't specify a required_ruby_version in our gemspec, and selenium-webdriver is a test-only dependency.

@thoughtbot-summer thoughtbot-summer changed the title Update selenium-webdriver and remove webdrivers Update selenium-webdriver and remove webdrivers; drop support for Ruby 2.7 Aug 18, 2023
@pablobm
Copy link
Copy Markdown
Collaborator

pablobm commented Sep 1, 2023

@nickcharlton wasn't sure about dropping support for Ruby 2.7 recently, so pinging him here 🙂 (I'm ok with dropping it).

@nickcharlton
Copy link
Copy Markdown
Member

I don't think we should drop it yet, even though it's EOL.

I've not been able to keep up with the recent Selenium changes, is stopping running any tests against it breaking that completely? Is there something else we can pin for older Ruby versions?

@pablobm
Copy link
Copy Markdown
Collaborator

pablobm commented Sep 1, 2023

I thought that webdrivers had the ability to download the correct (or in this case, pinned) version automatically? I guess this is not happening here. Could that be something that can be fixed? Am I mixing this up with something else?

@thoughtbot-summer
Copy link
Copy Markdown
Contributor Author

webdrivers has the ability to download the pinned version of the driver, but unfortunately it does not have the ability to download the corresponding version of the browser. Doing so is definitely possible (Puppeteer does it), but I'm not sure if there's a Ruby gem out there that provides that functionality.

@nickcharlton
Copy link
Copy Markdown
Member

Where are we on fixing Selenium/Webdrivers/etc? What should we do here?

The initial change seems to have settled down now and everything adjusted.

@pablobm
Copy link
Copy Markdown
Collaborator

pablobm commented Nov 24, 2023

I was just fixing my local setup yet again, and got it working with pretty much the same changes as in this PR.

@nickcharlton - Any thoughts on when it would be ok to drop Ruby 2.7?

nickcharlton pushed a commit that referenced this pull request Dec 12, 2023
This was originally introduced in #2419, but is worth breaking out.
@nickcharlton
Copy link
Copy Markdown
Member

I just opened #2469, which is the Ruby 2.7 removal. I figured that since we need that to do this, we should go about 2.7 now.

I cherry-picked @thoughtbot-summer's commit, so the change doesn't get lost when we built the CHANGELOG.

nickcharlton added a commit that referenced this pull request Dec 12, 2023
This was originally introduced in #2419, but is worth breaking out.

Co-authored-by: Summer ☀️ <summer@thoughtbot.com>
@nickcharlton nickcharlton force-pushed the selenium-chromium-greater-than-114 branch from a2487c8 to 64473e9 Compare December 12, 2023 15:00
@nickcharlton nickcharlton changed the title Update selenium-webdriver and remove webdrivers; drop support for Ruby 2.7 Update selenium-webdriver and remove webdrivers Dec 12, 2023
@nickcharlton nickcharlton merged commit c618988 into main Dec 12, 2023
@nickcharlton nickcharlton deleted the selenium-chromium-greater-than-114 branch December 12, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants