close
Skip to content

Trying out GitHub's code scanning tool#2154

Merged
pablobm merged 2 commits into
mainfrom
github-codeql
Aug 11, 2022
Merged

Trying out GitHub's code scanning tool#2154
pablobm merged 2 commits into
mainfrom
github-codeql

Conversation

@pablobm
Copy link
Copy Markdown
Collaborator

@pablobm pablobm commented Mar 3, 2022

@pablobm pablobm requested a review from nickcharlton March 3, 2022 18:00
@nickcharlton
Copy link
Copy Markdown
Member

nickcharlton commented Aug 8, 2022

This is neat! I tidied up the default workflow so that it's a lot smaller.

It's highlighted one issue we should fix in: spec/example_app/app/models/doc_page.rb:7

https://github.com/thoughtbot/administrate/security/code-scanning/1

Comment thread spec/example_app/app/models/doc_page.rb Fixed
Comment thread spec/example_app/app/models/doc_page.rb Fixed
@pablobm
Copy link
Copy Markdown
Collaborator Author

pablobm commented Aug 11, 2022

@nickcharlton - Fixed the security warning. I had to go out of my way a bit for the tool to accept it, as well as to be able to write a spec for it.

@nickcharlton
Copy link
Copy Markdown
Member

Oh nice, thanks!

@pablobm pablobm merged commit efe7aa6 into main Aug 11, 2022
@pablobm pablobm deleted the github-codeql branch August 11, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants