Sort dashboard attributes

[nhippenmeyer]

Sorting the fields listed in the ATTRIBUTE_TYPES hash of the dashboard file will make these files easier to maintain. For dashboards that contain a large number of attributes, it can be time-consuming/inefficient to find the correct line when making a change.

[nickcharlton]

Thanks for this!

I think if we're going to sort one of them, we should also sort the rest of the dashboard attributes. What do you think?

[pablobm]

I feel that id should go first by default. Thoughts?

Anecdotically, at work there's an admin interface I often have to look at (not Administrate-based) where everything sorted alphabetically, and I often end up scrolling right for a while until I find the ids...

[nickcharlton]

Yeah, I like that. It felt weird having id somewhere in the middle some times…

[nhippenmeyer]

I think if we're going to sort one of them, we should also sort the rest of the dashboard attributes. What do you think?

I'm happy to sort the attributes in COLLECTION_ATTRIBUTES, SHOW_PAGE_ATTRIBUTES and FORM_ATTRIBUTES as well, however I feel less strongly about that since those lists are typically reordered manually anyway based on the requirements of each dashboard.

I feel that id should go first by default. Thoughts?

I agree that id is more of special-case attribute and could make sense to put it first in the list. How do you feel about where created_at and updated_at should appear? Should they be at the bottom or sorted alphabetically with the rest of the attributes?

[nickcharlton]

Good point! We should put created_at/updated_at at the bottom, I think.

[pablobm]

Agreed: id first, standard timestamps last.

[nhippenmeyer]

@nickcharlton @pablobm mind taking another look?

[nickcharlton]

Ah hah, yeah, that works as I was hoping. I'm pondering how we can simplify the implementation, but I'm not getting anywhere today, any thoughts, @pablobm?

[nhippenmeyer]

@nickcharlton @pablobm I've made your suggested improvements. Does this look good now?

[pablobm]

Nice, let's merge this bad boi!