close
Skip to content

Add Rails 7 to tests#2132

Merged
nickcharlton merged 1 commit into
thoughtbot:mainfrom
jordan-brough:rails-7
Jan 26, 2022
Merged

Add Rails 7 to tests#2132
nickcharlton merged 1 commit into
thoughtbot:mainfrom
jordan-brough:rails-7

Conversation

@jordan-brough
Copy link
Copy Markdown
Contributor

@jordan-brough jordan-brough commented Jan 25, 2022

And refactor ".circleci/config" a bit. With all the current variations & limitations it seems like it's probably better to just list
the supported configurations explicitly rather than trying to share config blocks.

NOTE: I haven't actually tried running administrate on a Rails 7 app! But I intend to upgrade to Rails 7 and I saw that tests pass for it here so I thought it'd be worth opening a PR at least.

And refactor ".circleci/config" a bit.

With all the current variations & limitations it's probably better to just list
the supported configurations explicitly rather than trying to share config
blocks.
Copy link
Copy Markdown
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nickcharlton nickcharlton merged commit 1a6e0fc into thoughtbot:main Jan 26, 2022
shadoath pushed a commit to rinsed-org/administrate that referenced this pull request Mar 11, 2025
And refactor ".circleci/config" a bit.

With all the current variations & limitations it's probably better to just list
the supported configurations explicitly rather than trying to share config
blocks.
shadoath pushed a commit to rinsed-org/administrate that referenced this pull request Mar 12, 2025
And refactor ".circleci/config" a bit.

With all the current variations & limitations it's probably better to just list
the supported configurations explicitly rather than trying to share config
blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants