This repository was archived by the owner on Mar 1, 2024. It is now read-only.
feat(Button): add tabIndex property#417
Merged
Merged
Conversation
Greg-Hamel
approved these changes
Feb 11, 2019
Contributor
Greg-Hamel
left a comment
There was a problem hiding this comment.
Thanks for this addition, this is a good prop to have on-hand.
@AaronCoplan I think this can be merged.
jonthomp
approved these changes
Mar 11, 2019
Contributor
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the tabIndex property to the Button component. This allows for making buttons which can be ignored when tabbing to focus elements.
The GIF below demonstrates a button which can be focused by default by tabbing to it, however when it is given a tabIndex of "-1" it can no longer be highlighted by tabbing to it.