This repository was archived by the owner on Mar 1, 2024. It is now read-only.
fix camel-case capitalization of minLength and maxLength in FormInput component#416
Closed
ubergesundheit wants to merge 1 commit into
Closed
fix camel-case capitalization of minLength and maxLength in FormInput component#416ubergesundheit wants to merge 1 commit into
ubergesundheit wants to merge 1 commit into
Conversation
nerijunior
approved these changes
Feb 6, 2019
yildirayunlu
approved these changes
Mar 10, 2019
jonthomp
approved these changes
Mar 11, 2019
jonthomp
suggested changes
Mar 11, 2019
Contributor
jonthomp
left a comment
There was a problem hiding this comment.
@ubergesundheit I was tempted to just release this as minor bump rather than breaking change but sticking to the rules it should be breaking as you suggest 🤷♂️
What do you think about keeping all 4 options so we avoid breaking?
Author
|
Fine with me, as long as the warning is resolved. I'll see if keeping both options triggers the warning or not. |
83c1dda to
0a9f44c
Compare
Author
|
@jonthomp I tried your suggestion adding the correct properties instead of replacing, but this triggers the I am fine with this being merged into a major release. |
|
I'm starting to get annoyed by this error. When can you fix it? |
Contributor
|
Closing this and merging #440 instead as includes an additional fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed my tests and development versions printed out this warning when using Form.Input components:
This pull request fixes this issue by renaming
minlengthtominLengthandmaxlengthtomaxLengthinsrc/components/Form/FormInput.react.jsI guess this is somewhat a breaking change but it makes tabler-react more correct against the official standards.
Cheers!