Alter the path to version.h.#870
Merged
Merged
Conversation
This prevents the compiler from picking up htslib's version.h when C_INCLUDE_PATH=: (or similar).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the compiler from picking up htslib's
version.hwhen C_INCLUDE_PATH=: (or similar).From #817:
Simplest way to reproduce the error:
The
:in the C_INCLUDE_PATH is in effect adding-I.to the end of the gcc list of include paths while removing the original-I.from the start.So
gcc -g -O2 -DMAQ_LONGREADS -I. -Ihtslib-1.8 -I./lz4 -c -o misc/maq2sam-long.o misc/maq2sam.cbecomes
gcc -g -O2 -DMAQ_LONGREADS -Ihtslib-1.8 -I./lz4 -I. -c -o misc/maq2sam-long.o misc/maq2sam.cThough there is no apparent change in the command line, internally gcc removes any duplicate paths that are also in C_INCLUDE_PATH. This makes gcc find the htslib
version.hbefore the samtoolsversion.hso the build fails with a missing SAMTOOLS_VERSION.The gcc and clang compilers both exhibit this behaviour.
Fixes #817.