close
Skip to content

Subset specific TAGS#503

Closed
mh11 wants to merge 9 commits into
samtools:developfrom
mh11:develop
Closed

Subset specific TAGS#503
mh11 wants to merge 9 commits into
samtools:developfrom
mh11:develop

Conversation

@mh11
Copy link
Copy Markdown
Contributor

@mh11 mh11 commented Oct 24, 2016

These changes allow to customise the naming of tags and calculation of alleles by providing

  • a custom prefixes for tags
  • a list of sample IDs to calculate the tags for

Combined usage (prefix + samples)

By using these options in combination allows the calculation of e.g. EUR, SAS and * EAS* samples on the fly.

bcftools +fill-tags my.vcf.gz -- \
-S EUR_,my_eur.txt -S NOT_EUR_,^my_eur.txt \
-S SAS_,my_sas.txt \
-S EAS_,my_eas.txt | \
bgzip > my_annotated.vcf.gz

Prefix

Using a prefix ABC_ all tags (incl. description) will have the prefix added.
e.g. ABC_AN=.., ABC_AC=..,

Samples

Using a sample list allows the calculation of TAGS specific to this group of samples.
e.g. -S my_list.txt

@pd3
Copy link
Copy Markdown
Member

pd3 commented Oct 24, 2016

Hi, thank you for this pull request. There is a related plugin which should be merged with fill-tags at some point. Could you perhaps modify your pull request according to that? It is more general in that it annotates multiple populations simultaneously.

@mh11
Copy link
Copy Markdown
Contributor Author

mh11 commented Oct 26, 2016

Thanks for the suggestion - your related plugin is very similar in this sense. I’ll give it a go to modify the pull request.

On 24 Oct 2016, at 18:19, pd3 notifications@github.com wrote:

Hi, thank you for this pull request. There is a related plugin which should be merged with fill-tags at some point. Could you perhaps modify your pull request according to that? It is more general in that it annotates multiple populations simultaneously.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mh11
Copy link
Copy Markdown
Contributor Author

mh11 commented Oct 31, 2016

The latest commit gives you the flexibility to use multiple ID list in different ways (include/exclude) to annotate vcf files with custom headers.

@pd3
Copy link
Copy Markdown
Member

pd3 commented Nov 7, 2016

Thank you for this. Can you please check the failing tests?

@mh11
Copy link
Copy Markdown
Contributor Author

mh11 commented Nov 7, 2016

Done - checks are updated, additional test added and all passing.

@pd3
Copy link
Copy Markdown
Member

pd3 commented Nov 9, 2016

Hi, just added a minor improvement in -S initialization (1322e04) and merged. This pull request can be now closed. Thanks for this!

@pd3 pd3 closed this Nov 9, 2016
@mcshane mcshane mentioned this pull request Jan 12, 2017
4 tasks
pd3 added a commit that referenced this pull request Mar 1, 2017
With many groups, the original way of defining groups
(see #503) can
make the command line very long. In this commit this is
changed as in #445,
where single file with two columns is provided instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants