Adds Ruby 2.5 and 2.6 to Travis CI configuration#22
Merged
Conversation
Adds test coverage for newer versions of Ruby. Updates Ruby 2.3, 2.4, and 2.5 patch version to the latest available.
kou
requested changes
Aug 19, 2019
Member
kou
left a comment
There was a problem hiding this comment.
Could you use "2.4", "2.5" and "2.6"?
We can remove "2.3.x" because 2.3.x is EOL.
We can omit micro version to use the latest release.
When you omit the patch version from the rvm configuration, Travis CI will use the latest patch version available for that minor version of Ruby. i.e. specify version 2.6 will download 2.6.3 as of this commit.
Contributor
Author
|
Thanks for the feedback @kou. I have implemented the requested changes. Let me know if there's anything more I can do to help. |
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for new minor versions of Ruby 2. Updates Ruby 2.3, 2.4,
and 2.5 patch version to the latest available.