close
Skip to content

"+" is an acceptable character in apt package names#20

Closed
larskanis wants to merge 1 commit into
ruby:mainfrom
larskanis:patch-1
Closed

"+" is an acceptable character in apt package names#20
larskanis wants to merge 1 commit into
ruby:mainfrom
larskanis:patch-1

Conversation

@larskanis
Copy link
Copy Markdown
Contributor

... and there are actually packages like "g++", which were cut to package "g"

... and there are actually packages like "g++", which were cut to package "g"
larskanis added a commit to larskanis/fxruby that referenced this pull request Aug 1, 2022
@MSP-Greg
Copy link
Copy Markdown
Collaborator

MSP-Greg commented Aug 1, 2022

@larskanis

Thanks, good catch. I looked thru the MSYS2 packages I have installed locally; I couldn't find one with a + character. Also, looked at the current vcpkg ports, and couldn't find one. Both use the common.js function:

export const getInput = (name) => core.getInput(name).replace(/[^a-z_ \d.-]+/gi, '').trim().toLowerCase()

So, as you've done, I think the plus is probably best just added to apt-get. By change, do you run macOS? The @ character is added to its regex, not sure why I did that? Also not sure whether + should be added for brew?

@larskanis
Copy link
Copy Markdown
Contributor Author

homebrew has "+" characters in the package names as well: https://formulae.brew.sh/formula/libxml++3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants