close
Skip to content

Fixes phpcs errors and warnings#225

Merged
chandrapatel merged 4 commits into
masterfrom
fix/phpcs-issues
Dec 23, 2019
Merged

Fixes phpcs errors and warnings#225
chandrapatel merged 4 commits into
masterfrom
fix/phpcs-issues

Conversation

@chandrapatel

Copy link
Copy Markdown
Contributor

No description provided.

@thrijith thrijith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrapatel minor query with JS files.

Comment thread phpcs.xml Outdated
Co-Authored-By: Thrijith Thankachan <thrijith13@gmail.com>
@chandrapatel

Copy link
Copy Markdown
Contributor Author

@chandrapatel minor query with JS files.

@thrijith I have committed suggested changes.

Whitelist and ignore `append` usage in JS
@chandrapatel chandrapatel merged commit c3632f5 into master Dec 23, 2019
@chandrapatel chandrapatel deleted the fix/phpcs-issues branch December 23, 2019 15:19
@chandrapatel chandrapatel mentioned this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants