Added a typecast for check on purge_page_on_new_comment option for ne…#175
Merged
Conversation
…wly approved comments.
|
When will this PR appear in a release? Just updated to Nginx Helper 2.0.3 and still didn't fix this issue. @mbtamuli |
Contributor
Author
|
Please merge this simple and obvious fix. |
pradeep910
approved these changes
Jul 16, 2019
Collaborator
|
@pradeep910 any idea on when this fix will be released on a new version? thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New comments were not purging the post.
Using === for equality comparisons require both operands to be of the same type. Other instances of this and similar checks of integer-type options have the appropriate cast. Missing it here means new comments will not purge the post properly.