This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Emit more shutdown logging by default#1005
Merged
Merged
Conversation
mathyourlife-reddit
approved these changes
Oct 23, 2024
Contributor
mathyourlife-reddit
left a comment
There was a problem hiding this comment.
Sounds good. It's only a couple lines total (vs a per request line or something) and +1 to providing better visibility to how the server is handling shutdown.
redloaf
approved these changes
Oct 23, 2024
mjbonifacio
approved these changes
Oct 23, 2024
mjbonifacio
left a comment
There was a problem hiding this comment.
+1 great for visibility, excited to pick up these changes
RyanBalfanz
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default we only print out INFO level logs, so we only get the final
Exitingmessage and not the messages about draining or gracefully shutting down. This makes it hard to correlate errors around shutdown time with the server's shutdown sequence.Promoting these to INFO logs is worth it IMO since errors around shutdown are a common problem.