feat: Add classname to distinguish between leaf nodes or parent nodes by EmilyyyLiu · Pull Request #912 · react-component/tree

EmilyyyLiu · 2025-01-03T06:37:54Z

Summary by CodeRabbit

样式调整
- 为树节点添加了叶子节点的样式类，根据节点是否有子元素动态应用样式
测试增强
- 新增测试用例，验证树节点的叶子类名正确应用于无子元素的节点

vercel · 2025-01-03T06:37:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tree	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 7, 2025 1:44am

coderabbitai · 2025-01-03T06:38:01Z

变更概览

概述

本次变更主要针对 src/TreeNode.tsx 文件中的 className 分配进行了调整。通过添加基于 memoizedIsLeaf 变量的条件类，改进了树节点的视觉区分。变更保留了现有的拖放功能和组件逻辑，仅在样式呈现上做了细微调整。

变更

文件	变更摘要
`src/TreeNode.tsx`	修改 `className` 构建逻辑，增加 `${context.prefixCls}-treenode-leaf` 类名区分父节点和叶子节点
`tests/Tree.spec.tsx`	添加测试用例，验证树节点的叶子类名应用

可能相关的 PR

refactor: rewrite TreeNode CC => FC #905：重构 TreeNode 组件，与本 PR 的 className 修改直接相关。
chore: adjust code order #907：调整 TreeNode 组件的状态管理，涉及 memoizedIsLeaf 变量的处理。

建议的审阅者

MadCcc
afc163
zombieJ

诗歌庆祝

🐰 树节点跳舞，类名闪亮
父与子轻轻分明
代码如诗，样式如歌
兔子微笑，变更完成

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adfa72d and db0c614.

📒 Files selected for processing (1)

tests/Tree.spec.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/Tree.spec.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/TreeNode.tsx (1)

419-419: 建议与现有 memoizedIsLeaf 逻辑保持一致。
当前通过 data?.children 判断是否为父级节点或叶节点，可能和 memoizedIsLeaf 判断方式不一致，导致在某些情况下标签的赋值不准确。若要兼容更多使用场景，建议与既有逻辑统一判断条件。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e1dd54 and 7d8015b.

📒 Files selected for processing (1)

src/TreeNode.tsx (1 hunks)

🔇 Additional comments (1)

src/TreeNode.tsx (1)

416-418: 代码整体逻辑正常，可读性良好。
这些行的改动没有明显错误，保持了现有结构与命名习惯。

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 071b8c5 and ee76020.

⛔ Files ignored due to path filters (3)

tests/__snapshots__/Tree.spec.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/TreeNodeProps.spec.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/TreeProps.spec.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

src/TreeNode.tsx (1 hunks)
tests/Tree.spec.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/TreeNode.tsx

🧰 Additional context used

🪛 eslint

tests/Tree.spec.tsx

[error] 1334-1334: 'result' is never reassigned. Use 'const' instead.

(prefer-const)

🔇 Additional comments (1)

tests/Tree.spec.tsx (1)

1315-1354: 测试覆盖良好，逻辑清晰。
此用例充分验证了新增的叶子节点 className 功能，对含有子项与不含子项的节点都进行了正确的断言。对于区分叶子节点的需求而言，该测试方案简洁明了，能够在后续改动时有效防止回归缺陷。

🧰 Tools

🪛 eslint

[error] 1334-1334: 'result' is never reassigned. Use 'const' instead.

(prefer-const)

codecov · 2025-01-03T09:55:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (8e1dd54) to head (db0c614).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #912   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          14       14           
  Lines        1275     1275           
  Branches      392      389    -3     
=======================================
  Hits         1273     1273           
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

刘欢 added 2 commits January 3, 2025 14:24

feat：给tree的叶子节点增加一个class，供使用者识别选中

06fd390

feat:增加节点标识

7d8015b

vercel Bot deployed to Preview January 3, 2025 06:38 View deployment

coderabbitai Bot reviewed Jan 3, 2025

View reviewed changes

zombieJ reviewed Jan 3, 2025

View reviewed changes

Comment thread src/TreeNode.tsx Outdated

feat：取消parent节点标记

071b8c5

vercel Bot deployed to Preview January 3, 2025 06:52 View deployment

feat：添加测试文件，更新快照

ee76020

vercel Bot deployed to Preview January 3, 2025 08:15 View deployment

coderabbitai Bot reviewed Jan 3, 2025

View reviewed changes

Comment thread tests/Tree.spec.tsx Outdated

feat:let -> const

fe22c13

vercel Bot deployed to Preview January 3, 2025 08:53 View deployment

zombieJ reviewed Jan 3, 2025

View reviewed changes

Comment thread src/TreeNode.tsx Outdated

feat：判断变量使用已有的

f4a80f0

vercel Bot deployed to Preview January 3, 2025 09:15 View deployment

feat:变量修改

b3c9ee4

vercel Bot deployed to Preview January 3, 2025 09:49 View deployment

feat:修改快照

f0d0189

vercel Bot deployed to Preview January 3, 2025 09:54 View deployment

yoyo837 reviewed Jan 4, 2025

View reviewed changes

Comment thread src/TreeNode.tsx Outdated

li-jia-nan changed the title ~~feat：Add a classname to distinguish between leaf nodes or parent nodes~~ feat: Add classname to distinguish between leaf nodes or parent nodes Jan 4, 2025

feat:rc-tree-leaf改为rc-tree-treenode-leaf

a1586fd

vercel Bot deployed to Preview January 6, 2025 01:31 View deployment

zombieJ reviewed Jan 6, 2025

View reviewed changes

Comment thread tests/Tree.spec.tsx Outdated

feat:修改单测

adfa72d

vercel Bot deployed to Preview January 7, 2025 01:37 View deployment

feat:修改单测

db0c614

vercel Bot deployed to Preview January 7, 2025 01:44 View deployment

zombieJ approved these changes Jan 7, 2025

View reviewed changes

zombieJ merged commit c62d569 into react-component:master Jan 7, 2025

yoyo837 mentioned this pull request Jan 7, 2025

chore: upgrade [rc-tree] to [~5.13.0],upgrade [rc-cascader] to [~3.33… ant-design/ant-design#52274

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add classname to distinguish between leaf nodes or parent nodes#912

feat: Add classname to distinguish between leaf nodes or parent nodes#912
zombieJ merged 11 commits into
react-component:masterfrom
EmilyyyLiu:liuh-0103

EmilyyyLiu commented Jan 3, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 3, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

EmilyyyLiu commented Jan 3, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

变更概览

概述

变更

可能相关的 PR

建议的审阅者

诗歌庆祝

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EmilyyyLiu commented Jan 3, 2025 •

edited by coderabbitai Bot

Loading

vercel Bot commented Jan 3, 2025 •

edited

Loading

coderabbitai Bot commented Jan 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented Jan 3, 2025 •

edited

Loading