close
Skip to content

bpo-34154: Fix the docstring of the Listbox class.#8379

Closed
noahhaasis wants to merge 5 commits into
python:masterfrom
noahhaasis:fix-issue-34154
Closed

bpo-34154: Fix the docstring of the Listbox class.#8379
noahhaasis wants to merge 5 commits into
python:masterfrom
noahhaasis:fix-issue-34154

Conversation

@noahhaasis
Copy link
Copy Markdown
Contributor

@noahhaasis noahhaasis commented Jul 21, 2018 •
edited by bedevere-bot
Loading

This adds the valid keyword arguments for the init function to it's docstring.

https://bugs.python.org/issue34154

@noahhaasis
Remove the trailing whitespace
8f5aeb3
@noahhaasis
Add missing keyword arguments to the docs.
af08fab 
Added missing keywordarguments for following classes:
TopLevel, Checkbutton, Entry, Frame, Label, Radiobutton, Text, Spinbox
@noahhaasis
Remove trailing whitespace
430b207
@noahhaasis
Put typo back in to make the tests pass
2ff71c5
@csabella
Copy link
Copy Markdown
Contributor

csabella commented Jan 20, 2019

@noahhaasis Can you please include the additional changes that were part of #8396? Thanks!

csabella
csabella requested changes Apr 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahhaasis Can you please include the additional changes that were part of #8396? Thanks!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 9, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented May 31, 2019

@noahhaasis, I'm going to close this since there's been no response to the code review. If you come back to this at some point, we can re-open it. Thank you for your work!

@csabella csabella closed this May 31, 2019
@CreationElemental CreationElemental mannequin mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella csabella requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noahhaasis @csabella @bedevere-bot @the-knights-who-say-ni