Document hpack logger configuration#292
Closed
Mirochill wants to merge 1 commit into
Closed
Conversation
Member
|
I think the best practice is to use the approach outlined in https://stackoverflow.com/a/35326281 instead of introducing a new log level in hpack itself. |
Signed-off-by: Miro <200482516+Mirochill@users.noreply.github.com>
7325250 to
6c9c93b
Compare
Author
|
Thanks, adjusted in that direction. I removed the custom Static checks run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEBUGlogging while raising thehpacklogger levelRefs #273
Tests
git diff --checkgit diff --check origin/master..HEADgit show --check --stat --oneline HEAD