Remove redundant fields from WantsOutputs event#1102
Merged
arminsabouri merged 1 commit intoSep 22, 2025
Conversation
The primary information obtained from `OutputsUnknown` to `WantsOutputs` is the index of the receiver outputs. The rest of the information can be obtained from the previous state(s).
Collaborator
Pull Request Test Coverage Report for Build 17917096584Details
💛 - Coveralls |
DanGould
reviewed
Sep 22, 2025
| params: Params, | ||
| change_vout: usize, | ||
| owned_vouts: Vec<usize>, | ||
| pub(crate) owned_vouts: Vec<usize>, |
Contributor
There was a problem hiding this comment.
big nit, but wouldn't the cleaner pattern be a SessionEvents constructor from owned_vouts or a pub(crate) fn owned_vouts getter? Incongruent field accessibility is a tiny smell.
( a SessionEvent constructor or From impl on Wantsoutputs might also work)
Contributor
Author
There was a problem hiding this comment.
A getter would work fine but it will need to be feature flagged. IIRC in previous Prs we have a preference for pub(crate) over feature flags in common code.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary information obtained from
OutputsUnknowntoWantsOutputsis the index of the receiver outputs. The rest of the information can be obtained from the previous state(s).related ticket #1103
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.