close
Skip to content

fix(luarocks-upload): make sure correct archive is uploaded#444

Merged
Conni2461 merged 1 commit into
nvim-lua:masterfrom
mrcjkb:mrcjk/luarocks-workflow-url-fix
Jan 6, 2023
Merged

fix(luarocks-upload): make sure correct archive is uploaded#444
Conni2461 merged 1 commit into
nvim-lua:masterfrom
mrcjkb:mrcjk/luarocks-workflow-url-fix

Conversation

@mrcjkb
Copy link
Copy Markdown
Contributor

@mrcjkb mrcjkb commented Jan 6, 2023

@Conni2461

the upload script's sed call replaces 'scm' in the following section:

if _MODREV == 'scm' then
   source = {
      url = 'git://github.com/nvim-lua/plenary.nvim',
   }
end

This PR makes sure it only replaces the declaration at the top of the file:

local _MODREV, _SPECREV = 'scm', '-1'

@Conni2461

the upload script's `sed` call replaces `'scm'` in the following
section:
```lua
if _MODREV == 'scm' then
   source = {
      url = 'git://github.com/nvim-lua/plenary.nvim',
   }
end
```
This PR makes sure it only fixes the declaration at the top of the
file.
@Conni2461 Conni2461 merged commit 9d81624 into nvim-lua:master Jan 6, 2023
@Conni2461
Copy link
Copy Markdown
Collaborator

Thanks :)

@mrcjkb mrcjkb deleted the mrcjk/luarocks-workflow-url-fix branch January 6, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants