close
Skip to content

chore: migrate core interfaces and utilities to ESM#5930

Merged
mark-wiemer merged 5 commits into
mochajs:mainfrom
mostafaNazari702:chore/esm-migration-phase-three
May 2, 2026
Merged

chore: migrate core interfaces and utilities to ESM#5930
mark-wiemer merged 5 commits into
mochajs:mainfrom
mostafaNazari702:chore/esm-migration-phase-three

Conversation

@mostafaNazari702
Copy link
Copy Markdown
Contributor

@mostafaNazari702 mostafaNazari702 commented May 1, 2026

PR Checklist

Overview

Phase three of the migration to ESM.

@mostafaNazari702 mostafaNazari702 force-pushed the chore/esm-migration-phase-three branch from c3726d8 to 8fa48fa Compare May 1, 2026 19:16
@mostafaNazari702
Copy link
Copy Markdown
Contributor Author

@mark-wiemer test files received forced path-only adjustments only. Which indirectly has to go against your "...Except the test files!..."-instruction.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.95%. Comparing base (f6a62ca) to head (99325a4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/interfaces/bdd.mjs 0.00% 4 Missing ⚠️
lib/interfaces/qunit.mjs 0.00% 4 Missing ⚠️
lib/interfaces/tdd.mjs 0.00% 4 Missing ⚠️
lib/cli/one-and-dones.mjs 0.00% 2 Missing ⚠️
lib/interfaces/common.mjs 0.00% 1 Missing ⚠️
lib/test.mjs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5930      +/-   ##
==========================================
- Coverage   88.14%   80.95%   -7.20%     
==========================================
  Files          65       64       -1     
  Lines        4615     4579      -36     
  Branches      976      978       +2     
==========================================
- Hits         4068     3707     -361     
- Misses        547      872     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mostafaNazari702 mostafaNazari702 changed the title chore: migrate core interfaces and utilities to ESM (phase three) chore: migrate core interfaces and utilities to ESM May 1, 2026
Comment thread lib/interfaces/tdd.mjs
Comment thread lib/errors.mjs Outdated
Comment thread lib/mocha.js Outdated
Comment thread lib/mocha.js
Comment thread lib/plugin-loader.mjs Outdated
Comment thread lib/runner.js Outdated
@mark-wiemer
Copy link
Copy Markdown
Member

Looks great! integration failure is known issue (#5361), requires failure is Codecov transient failure.

Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copy link
Copy Markdown
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna walk the dog and hope I didn't break anything. Thanks again!

@mark-wiemer
Copy link
Copy Markdown
Member

@mark-wiemer test files received forced path-only adjustments only. Which indirectly has to go against your "...Except the test files!..."-instruction.

@mostafaNazari702 you did exactly what I wanted :) the test files need to be changed, but it's not a priority right now to convert them to ESM. Good work :)

@mark-wiemer
Copy link
Copy Markdown
Member

Failure is a known issue, merging :)

@mark-wiemer mark-wiemer merged commit 1ad23ab into mochajs:main May 2, 2026
76 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants