chore: migrate core interfaces and utilities to ESM#5930
Conversation
c3726d8 to
8fa48fa
Compare
|
@mark-wiemer test files received forced path-only adjustments only. Which indirectly has to go against your "...Except the test files!..."-instruction. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5930 +/- ##
==========================================
- Coverage 88.14% 80.95% -7.20%
==========================================
Files 65 64 -1
Lines 4615 4579 -36
Branches 976 978 +2
==========================================
- Hits 4068 3707 -361
- Misses 547 872 +325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks great! integration failure is known issue (#5361), |
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
mark-wiemer
left a comment
There was a problem hiding this comment.
Gonna walk the dog and hope I didn't break anything. Thanks again!
@mostafaNazari702 you did exactly what I wanted :) the test files need to be changed, but it's not a priority right now to convert them to ESM. Good work :) |
|
Failure is a known issue, merging :) |
PR Checklist
status: accepting prsOverview
Phase three of the migration to ESM.