close
Skip to content

chore(v11.x): release 11.7.6#5632

Merged
mark-wiemer merged 1 commit into
v11.xfrom
release-please--branches--v11.x--components--mocha
May 18, 2026
Merged

chore(v11.x): release 11.7.6#5632
mark-wiemer merged 1 commit into
v11.xfrom
release-please--branches--v11.x--components--mocha

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jan 7, 2026

🤖 I have created a release beep boop

11.7.6 (2026-02-14)

🩹 Fixes

  • make describe().timeout() work (aafe6fd)
  • test: replace wmic usage with native Windows API (#5694) (73ebdfa)

🧹 Chores


This PR was generated with Release Please. See documentation.

@github-actions github-actions Bot force-pushed the release-please--branches--v11.x--components--mocha branch from 3a5d5f6 to c1d4540 Compare January 7, 2026 15:23
@hlovdal
Copy link
Copy Markdown

hlovdal commented Jan 15, 2026

Please make sure that #5605 is included in this release, because it fixes a security dependency issue.

Also, even though "^8.0.2" will allow for moving forward to 8.0.3 which contains the fix, it would be better to explicitly require minimum that version, e.g.

"diff": "^8.0.3",

hlovdal added a commit to hlovdal/node-red-node-test-helper that referenced this pull request Jan 15, 2026
While waiting for upstream project to update its dependency,
mochajs/mocha#5632

Fixes GHSA-73rr-hh4g-fpgx.
hlovdal added a commit to hlovdal/hlovdal-node-red-lowercase-in-typescript that referenced this pull request Jan 15, 2026
While waiting for mocha and sinon to make new releases using the fixed
diff package.

mochajs/mocha#5632

Fixes GHSA-73rr-hh4g-fpgx.
hlovdal added a commit to hlovdal/hlovdal-node-red-lowercase-in-typescript that referenced this pull request Jan 15, 2026
While waiting for mocha and sinon to make new releases using the fixed
diff package.

mochajs/mocha#5632

Fixes GHSA-73rr-hh4g-fpgx.
@mark-wiemer
Copy link
Copy Markdown
Member

As Josh said in #5650 (comment):

With love and appreciation, joshuakgoldberg.com/blog/please-stop-sending-me-nested-dependency-security-reports

I'll add: this vulnerability does not affect Mocha. Unless you're using it to parse files you don't own, there is nothing risky. The first line of the advisory is clear:

Attempting to parse a patch whose filename headers contain the line break characters \r, \u2028, or \u2029 can cause the parsePatch method to enter an infinite loop. It then consumes memory without limit until the process crashes due to running out of memory.

This is at the very worst a mild inconvenience for Mocha users, as they have to find their relevant test files and rename them. No security risk.

Please, if you think there's a risk, reproduce the actual issue (not just the warning) before pinging here.

@github-actions github-actions Bot force-pushed the release-please--branches--v11.x--components--mocha branch from c1d4540 to b9dd1e3 Compare January 29, 2026 04:49
@Seb33300
Copy link
Copy Markdown

Seb33300 commented Feb 4, 2026

@mark-wiemer Even if the risk is theoretical in Mocha, the presence of a known CVE still triggers security scanners and audit findings for downstream users. Some security certifications and compliance frameworks do not allow shipping dependencies with known vulnerabilities, regardless of exploitability.

And you cannot assume or enforce how dependencies are used downstream. Providing a fix is the safest default.

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

Even if the risk is theoretical in Mocha

It is not theoretical. This security vulnerability does not impact Mocha.

security scanners and audit findings
Some security certifications and compliance frameworks do not allow shipping dependencies with known vulnerabilities, regardless of exploitability.

That is where the problem lies. It's a "boy who cried wolf" situation.

From another perspective: we have an extremely limited budget maintaining Mocha. It has been years since more than two maintainers have been regularly active for any sustained amount of time, and in those years, no maintainer has ever been able to spend more than part-time effort on the project. We, like the vast majority of open source projects, are understaffed and overwhelmed with the bare minimum of work to keep the project going.

Security scanners regularly report false positives without applying nuance to who those packages impact. This creates a great deal of noise in the ecosystem and causes extra work for overloaded projects like Mocha. Which is improper, unfair, and detrimental to the ecosystem. It's a waste of our time to try to take action -let alone urgently- on incorrect security reports that do not impact Mocha. That takes away time from other, actually user-benefitting work.

Speaking of which, we will soon release the next, beta-7 version of Mocha 12 currently released: mocha@12.0.0-beta-6. That version of Mocha both includes the requested bump of the diff package as well as several more package upgrades that rely on being able to require(esm). Rather than playing wack-a-mole with false positive security reports in v11, we will prioritize getting v12 shipped.

I think it's great that you're looking at the security reports and advocating for it (really, a super positive & beneficial thing!). But getting Mocha to respond to incorrect security reports is not long-term optimally helpful for users of Mocha. The best places you could try to make better here would be for security reporting mechanisms such as npm audit that produce incorrect reports, cause compliance frameworks to needlessly block package updates based on those reports, and reduce trust in security reporting mechanisms altogether.

@voxpelli
Copy link
Copy Markdown
Member

voxpelli commented Feb 4, 2026

Some security certifications and compliance frameworks do not allow shipping dependencies with known vulnerabilities

It's very rare to ship something with mocha as a non-dev dependency?

Also: Lockfile maintenance is key. Do an npm update or such. Only if something in our dependency chain would demand you to use a security flagged version would it need us to act in my mind.

@github-actions github-actions Bot force-pushed the release-please--branches--v11.x--components--mocha branch from b9dd1e3 to 56c0525 Compare February 14, 2026 02:00
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) May 16, 2026 14:31
@JoshuaKGoldberg JoshuaKGoldberg disabled auto-merge May 16, 2026 14:32
@JoshuaKGoldberg
Copy link
Copy Markdown
Member

JoshuaKGoldberg commented May 16, 2026

Err, the v11.x ref is protected. How do we get this released? Should I --admin merge this?

@mark-wiemer
Copy link
Copy Markdown
Member

@JoshuaKGoldberg sorry for the issues, I set this up and I can edit the branch rule to make this easier, let me do that now...

@mark-wiemer
Copy link
Copy Markdown
Member

I had wrongly checked the "Restrict updates" box, I've unchecked it and now we can merge, I'll merge now :)

@mark-wiemer mark-wiemer merged commit 3765ba0 into v11.x May 18, 2026
2 checks passed
@mark-wiemer mark-wiemer deleted the release-please--branches--v11.x--components--mocha branch May 18, 2026 04:06
@github-actions
Copy link
Copy Markdown
Contributor Author

🤖 Created releases:

🌻

@dlockhart
Copy link
Copy Markdown

Exciting to see this released, but should this have published 11.7.6 to npm or is that a separate workflow?

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

JoshuaKGoldberg commented May 20, 2026

Ah, right, we have to manually approve these. https://github.com/mochajs/mocha/actions/runs/26012935644 was waiting on us. I approved just now. Thanks for the prod 😄

@torokati44
Copy link
Copy Markdown

Ooh, it failed. 😐

@dlockhart
Copy link
Copy Markdown

dlockhart commented May 20, 2026

It's possible that you may need to rotate your token if you're using a granular one -- npm invalidated them all last night due to the ongoing Shai Hulud attacks.

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

sigh. Thanks. https://www.npmjs.com/package/mocha/v/11.7.6 is now published.

Our CI system was, in fact, using an old npm token. I set up a new one that'll expire in a week. We'll have to rework our trusted publishing setup a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants