Added the VSCode-SessionId for extension queries Issue2961#153271
Merged
Conversation
Adding the `VSCode-sessionId` header to extension query request
sandy081
requested changes
Jun 27, 2022
sandy081
requested changes
Jun 27, 2022
| } | ||
| }); | ||
|
|
||
| class MockTelemetryService implements ITelemetryService { |
Member
There was a problem hiding this comment.
Please use the NullTelemetryService instead
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed it!
What is the best way to send PR, should I talk to you first?
I am still getting familiar with the code base; I don't want to be wasting your time in review :)
Member
There was a problem hiding this comment.
Either way works. If it is a small one like this, you can go ahead and create a PR like here and ask for review. If its a big change reaching out and discussing will definitely save time for you 👍
sandy081
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
VSCode-SessionIdfor extension queries