Track the cursor dirty flag in the correct buffer#20095
Merged
Hidden character warning
The head ref may contain hidden characters: "dev/duhowett/\ud83d\udcc5"
Conversation
Failure to do so will result in every console API requiring a cursor update stalling for 500ms because we sent the update to the wrong buffer. Fixes #20092
lhecker
approved these changes
Apr 8, 2026
Member
lhecker
left a comment
There was a problem hiding this comment.
It would be neat if this PR could also address the CUP leak we found. 🫣
Member
Author
I'd rather fix that on its own. I'm also going to change the names of all these functions so it is crystal clear what they do. |
|
Could this crash if activeBuffer is the alt buffer and another thread switches back to the main buffer while WaitForConptyCursorPositionToBeSynchronized() is waiting, since the alt buffer can be deleted in that window? |
Member
Author
|
Nope. The console I/O handler is single-threaded, and the only way to get out of the alt buffer is by processing |
Qmoony
pushed a commit
to Qmoony/terminal
that referenced
this pull request
May 11, 2026
Failure to do so will result in every console API requiring a cursor update stalling for 500ms because we sent the update to the wrong buffer. Closes microsoft#20092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure to do so will result in every console API requiring a cursor update stalling for 500ms because we sent the update to the wrong buffer.
Closes #20092