Avoid scrolling when the search is open#19775
Merged
Merged
Conversation
Member
OK, I tested this out. It doesn't prevent the highlighting of newly-found results, only the action where we jump TO a result. |
DHowett
approved these changes
Jan 24, 2026
DHowett
pushed a commit
that referenced
this pull request
Feb 27, 2026
When text scrolls in and out of view, depending on the length of the scrollback and latency of input, `GetSearchHighlightFocused` would change which would trigger a `ScrollToSearchHighlight` call. This PR changes the behavior such that only actively changing the search mask triggers a search (typing text or pressing enter). Closes #19754 ## Validation Steps Performed * Brining text in and out of view doesn't scroll ✅ * Toggling the aA button scrolls results into view ✅ (cherry picked from commit 71409f8) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgkLCdk Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When text scrolls in and out of view, depending on the length
of the scrollback and latency of input,
GetSearchHighlightFocusedwould change which would trigger a
ScrollToSearchHighlightcall.This PR changes the behavior such that only actively changing the
search mask triggers a search (typing text or pressing enter).
Closes #19754
Validation Steps Performed