Switch to the new and beautiful VS Dev Shell icons#17706
Merged
Conversation
|
Will these icons apply to Terminal profiles for older installations of Visual Studio, like 2019 or 2017? It may be fine to use the 2022 icons for all of them, but it's worth noting. |
Member
Author
For now, they will. They'll also be used for Preview even though the VS logo differs between Stable and Preview. However, this pull request also sets us up to change them in the future without having to break user settings. 🙂 |
lhecker
approved these changes
Aug 13, 2024
Member
Author
|
/cc @zadjii-msft we made the explicit choice to stop serializing |
DHowett
added a commit
that referenced
this pull request
Aug 20, 2024
We got some new icons for Developer Command Prompt and Developer PowerShell from our friends over on Visual Studio! This pull request includes them in the package, and fixes up the VS dynamic profiles to reset any icons that matched the old paths. This may be a minor breaking change for user settings, but we're making the assumption that if they didn't change their VS profile icons from the defaults, they probably want to follow us to the new defaults. To prevent anything like this from happening again, we're going to stop serializing icons for stub profiles. I've also included a VS version of the PowerShell "black" icon which is currently unused, but can be used in the future for PS7+-based VS Dev Shell. Closes #17627 (cherry picked from commit 06c07ab) Service-Card-Id: 93531228 Service-Version: 1.20
DHowett
added a commit
that referenced
this pull request
Aug 20, 2024
We got some new icons for Developer Command Prompt and Developer PowerShell from our friends over on Visual Studio! This pull request includes them in the package, and fixes up the VS dynamic profiles to reset any icons that matched the old paths. This may be a minor breaking change for user settings, but we're making the assumption that if they didn't change their VS profile icons from the defaults, they probably want to follow us to the new defaults. To prevent anything like this from happening again, we're going to stop serializing icons for stub profiles. I've also included a VS version of the PowerShell "black" icon which is currently unused, but can be used in the future for PS7+-based VS Dev Shell. Closes #17627 (cherry picked from commit 06c07ab) Service-Card-Id: 93531229 Service-Version: 1.21
4 tasks
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 24, 2026
## Summary of the Pull Request This PR updates `VsDevShellGenerator` to use the `vs-pwsh` icon in generated profiles, if modern PowerShell has been detected. ## References and Relevant Issues The icons were added in #17706, but are not used anywhere. ## Detailed Description of the Pull Request / Additional comments * Updated `VsDevShellGenerator::GetProfileCommandLine` to accept a `bool& isPwsh` parameter, which is set to whether the generated profile command line is using modern PowerShell. This value gets passed to `VsDevShellGenerator::GetProfileIconPath`'s new parameter, which determines whether to return the icon for `powershell` or `pwsh`.
DHowett
pushed a commit
that referenced
this pull request
Apr 3, 2026
## Summary of the Pull Request This PR updates `VsDevShellGenerator` to use the `vs-pwsh` icon in generated profiles, if modern PowerShell has been detected. ## References and Relevant Issues The icons were added in #17706, but are not used anywhere. ## Detailed Description of the Pull Request / Additional comments * Updated `VsDevShellGenerator::GetProfileCommandLine` to accept a `bool& isPwsh` parameter, which is set to whether the generated profile command line is using modern PowerShell. This value gets passed to `VsDevShellGenerator::GetProfileIconPath`'s new parameter, which determines whether to return the icon for `powershell` or `pwsh`. (cherry picked from commit e040015) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgpBNIk Service-Version: 1.25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got some new icons for Developer Command Prompt and Developer PowerShell from our friends over on Visual Studio!
This pull request includes them in the package, and fixes up the VS dynamic profiles to reset any icons that matched the old paths.
This may be a minor breaking change for user settings, but we're making the assumption that if they didn't change their VS profile icons from the defaults, they probably want to follow us to the new defaults.
To prevent anything like this from happening again, we're going to stop serializing icons for stub profiles.
I've also included a VS version of the PowerShell "black" icon which is currently unused, but can be used in the future for PS7+-based VS Dev Shell.
Closes #17627