[rush] pnpm 3.5.3 + rush 5.9.1 `rush update` fails to link

[calebmshafer]

During the move to pnpm 3.5.3 and rush 5.9.1, I deleted the shrinkwrap file and ran a rush update --full --purge. It successfully makes it through the pnpm install step but fails during the linking phase and receive this error,

ERROR: Internal Error: Cannot find installed dependency "@microsoft/api-extractor" in "C:\dev\imodeljs\imodeljs\common\temp\node_modules\.local\C%3A%2Fdev%2Fimodeljs%2Fimodeljs%2Fcommon%2Ftemp%2Fprojects%2Fbuild-tools.tgz\node_modules"
You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.

The actual file path that exists in the .local folder for the package is, "C:\dev\imodeljs\imodeljs\common\temp\node_modules\.local\C%3A%2Fdev%2Fimodeljs%2Fimodeljs%2Fcommon%2Ftemp%2Fprojects%2Fbuild-tools.tgz_2a665c89609864b4e75bc5365d7f8f56".

It looks like this may be related to how pnpm resolves peer dependencies, https://pnpm.js.org/docs/en/how-peers-are-resolved.html, but that's just a guess based on some of the other paths in the .local folder,

"C:\dev\imodeljs\imodeljs\common\temp\node_modules\.local\C%3A%2Fdev%2Fimodeljs%2Fimodeljs%2Fcommon%2Ftemp%2Fprojects%2Fpresentation-frontend.tgz_jsdom@11.12.0"
"C:\dev\imodeljs\imodeljs\common\temp\node_modules\.local\C%3A%2Fdev%2Fimodeljs%2Fimodeljs%2Fcommon%2Ftemp%2Fprojects%2Fpresentation-integration-tests.tgz_jsdom@11.12.0"

If you'd like to reproduce the issue, the iModel.js repo when updated to use the new rush and pnpm versions will work. I can always make a separate repro repo if needed with the updated versions.

[sachinjoseph]

Thanks @calebmshafer. It will help if you can provide repro repo and repro steps with the latest version of Rush.

[sachinjoseph]

pnpm 3.5.3 is known to be incompatible with Rush version <= 5.9.1.

[calebmshafer]

Just setup the repro repo here, https://github.com/calebmshafer/imodeljs_rush_bug_repro.

The steps are,

1. Delete common\config\rush\shrinkwrap.yaml
2. Run node common\scripts\install-run-rush.js update

Then you should see the error pasted above.

[calebmshafer]

FWIW, I can reproduce this with Rush 5.10.0 as well.

I have been following #1142, as we've been experiencing the same issue, and with the fix pushed I attempted to update to the latest pnpm and Rush. That's when I discovered this problem.

[sachinjoseph]

I can repro this on Rush 5.10.0 and pnpm 3.5.3. Looking into this.

[kelseyyoung]

I think I've seen this; I believe it's because you're missing peer dependencies in your package.json required by a different package you depend on

So for example in your second text block you probably need to depend on jsdom because another package you require has a peer dependency on it

[agrittmsft]

Seems to not be an issue if you use Rush 5.10.0 and pnpm 2.25.6.

[cortopy]

Same error here with a different package. I've tried patching the dependency by moving the peer dependency into a proper dependency, but issue persists.
Using pnpm 2.25.6 also works for me

[calebmshafer]

It works with pnpm 2.25.7 as well, that's the version we're currently stuck on. I haven't tracked down all of the peer dependencies and promoted them to real dependencies but I can see if that works.

[sachinjoseph]

#1367

[apostolisms]

@calebmshafer this should be fixed now in version 5.10.1