feat: [FLAC] drop io.Closer element in Stream and Encoder types#70
Merged
mewmew merged 3 commits intoMay 8, 2024
Merged
Conversation
… encoder's closer, since bitio.Writer does not close the underlying writer
Member
|
Hi @zalgonoise! Thanks for submitting the PR. I agree that the code looks cleaner in the way you wrote it. Happy to merge : ) Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
io.Closertype is taken only if the underlyingio.Reader(forStream) andio.Writer(forEncoder) implementsio.Closer.This being the case, there is no point in storing it as an additional element in these data structures. It both makes them simpler and shorter (minus one pointer type, considering that interfaces are stored as pointer types), and it also makes the code a bit more readable.
Another detail is the change in the encoder frames logic, which initializes a
bitio.Writerwhich wraps our Encoder's writer, and the Encoder's closer is replaced with thebitio.Writerinstance -- however,bitio.Writer.Closerdoes not close the underlying writer.