zstd: Improve best compression#360
Merged
Merged
Conversation
See if we can find a better match by checking where the current best ends. Use that offset to see if we can find a better full match. Before/after. Ignore speed, may not be comparable: ``` gob-stream zskp 4 1911399616 171537212 32113 56.76 gob-stream zskp 4 1911399616 167273881 29337 62.13 enwik9 zskp 4 1000000000 276609671 44029 21.66 enwik9 zskp 4 1000000000 275241169 36430 26.18 github-june-2days-2019.json zskp 4 6273951764 512796117 97791 61.18 github-june-2days-2019.json zskp 4 6273951764 503314661 93811 63.78 nyc-taxi-data-10M.csv zskp 4 3325605752 495986829 89368 35.49 nyc-taxi-data-10M.csv zskp 4 3325605752 490907191 65939 48.10 ```
mostynb
added a commit
to mostynb/zstdpool-syncpool
that referenced
this pull request
Apr 28, 2021
This includes the following zstd improvement since v1.12.1: * Add helpers to compress/decompress zstd inside zip files klauspost/compress#363 * Improve best compression klauspost/compress#360 * Improve better compression klauspost/compress#364 * Improve compression with dictionaries too klauspost/compress#365
mostynb
added a commit
to mostynb/go-grpc-compression
that referenced
this pull request
Apr 28, 2021
This includes the following zstd improvement since v1.12.1: * Add helpers to compress/decompress zstd inside zip files klauspost/compress#363 * Improve best compression klauspost/compress#360 * Improve better compression klauspost/compress#364 * Improve compression with dictionaries too klauspost/compress#365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See if we can find a better match by checking where the current best ends.
Use that offset to see if we can find a better full match.
Before/after. Ignore speed, may not be comparable: