close
Skip to content

Save BP register to XMM#349

Merged
klauspost merged 1 commit into
masterfrom
save-bp-register
Apr 7, 2021
Merged

Save BP register to XMM#349
klauspost merged 1 commit into
masterfrom
save-bp-register

Conversation

@klauspost

@klauspost klauspost commented Apr 6, 2021

Copy link
Copy Markdown
Owner

Keep BP in an XMM register while running.

See discussion on Slack and golang-dev

https://gophers.slack.com/archives/C6WDZJ70S/p1598210629000900
https://groups.google.com/g/golang-dev/c/aLn9t8tKg2o/m/Kw-N7lUuBAAJ

Summary:

  • BP should be callee-save (poorly documented, even some standard library assembly didn't handle this correctly until recently)

  • BP "will be saved automatically if there is a nonzero frame size" https://golang.org/cl/248260

  • Use the "nonzero frame size" hack in the case where BP has been used

Keep BP in an XMM register while running.
@klauspost klauspost merged commit c223fea into master Apr 7, 2021
@klauspost klauspost deleted the save-bp-register branch April 7, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant