Add support for interfaces on interfaces#1304
Merged
erikwrede merged 4 commits intoAug 13, 2022
Merged
Conversation
zbyte64
approved these changes
Jan 16, 2021
erikwrede
approved these changes
Aug 13, 2022
Member
erikwrede
left a comment
There was a problem hiding this comment.
Sorry for the long wait, this looks great!
erikwrede
added a commit
to erikwrede/graphene
that referenced
this pull request
Aug 13, 2022
erikwrede
added a commit
that referenced
this pull request
Aug 13, 2022
assert bar_graphql_type.interfaces == [foo_graphql_type] failed only on tox, because .interfaces was a tuple instead of a list. Error didn't occur using just pytest. Fixed by explicitly converting both to list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graphql-corealready supports specifying interfaces on interfaces. This change adds that support to graphene.For example, the interfaces from one of the added test cases would look like this in a printed schema:
I've tested these changes with a private schema and it seems to work as expected. There's some trickiness around getting graphql-core to resolve types properly but it's definitely doable.