UnnecessaryBoxedAssignment: avoid CCE on method reference#4157
Closed
Stephan202 wants to merge 1 commit into
Closed
UnnecessaryBoxedAssignment: avoid CCE on method reference#4157Stephan202 wants to merge 1 commit into
Stephan202 wants to merge 1 commit into
Conversation
56ef965 to
73dc358
Compare
Stephan202
commented
Oct 21, 2023
Contributor
Author
Stephan202
left a comment
There was a problem hiding this comment.
I did not really investigate what it would take to support method references, but I suspect that would be a check all by itself, if such a thing would make sense at all.
| } | ||
|
|
||
| void negative_methodReference() { | ||
| Function<String, Boolean> toBoolean = Boolean::valueOf; |
Contributor
Author
There was a problem hiding this comment.
Without the fix this triggers:
java.lang.ClassCastException: class com.sun.tools.javac.tree.JCTree$JCMemberReference cannot be cast to class com.sun.source.tree.MethodInvocationTree (com.sun.tools.javac.tree.JCTree$JCMemberReference and com.sun.source.tree.MethodInvocationTree are in module jdk.compiler of loader 'app')
at com.google.errorprone.bugpatterns.UnnecessaryBoxedAssignment.matchCommon(UnnecessaryBoxedAssignment.java:72)
at com.google.errorprone.bugpatterns.UnnecessaryBoxedAssignment.matchVariable(UnnecessaryBoxedAssignment.java:64)
cushon
approved these changes
Oct 21, 2023
cushon
approved these changes
Nov 1, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.