Support multi-value dimensions in downsampling (bug fix)#145458
Merged
elasticsearchmachine merged 4 commits intoApr 2, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
kkrik-es
approved these changes
Apr 1, 2026
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 2, 2026
) elastic#112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests. (cherry picked from commit 63dfd4a) # Conflicts: # modules/data-streams/src/main/java/org/elasticsearch/datastreams/DataStreamFeatures.java # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DimensionFieldDownsampler.java
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 2, 2026
) elastic#112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests. (cherry picked from commit 63dfd4a) # Conflicts: # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DimensionFieldProducer.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 2, 2026
) elastic#112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests. (cherry picked from commit 63dfd4a) # Conflicts: # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DimensionFieldDownsampler.java
gmarouli
added a commit
that referenced
this pull request
Apr 2, 2026
…) (#145536) * Support multi-value dimensions in downsampling (bug fix) (#145458) #112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests. (cherry picked from commit 63dfd4a) # Conflicts: # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DimensionFieldProducer.java * Fix test * Remove unnecessary warning
gmarouli
added a commit
that referenced
this pull request
Apr 2, 2026
…) (#145539) * Support multi-value dimensions in downsampling (bug fix) (#145458) #112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests. (cherry picked from commit 63dfd4a) # Conflicts: # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DimensionFieldDownsampler.java * Fix assertion * Remove unnecessary warning * Sampling method was implemented not in 9.2
gmarouli
added a commit
that referenced
this pull request
Apr 2, 2026
) (#145535) * Support multi-value dimensions in downsampling (bug fix) (#145458) #112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests. (cherry picked from commit 63dfd4a) # Conflicts: # modules/data-streams/src/main/java/org/elasticsearch/datastreams/DataStreamFeatures.java # x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DimensionFieldDownsampler.java * Remove allowed warnings * Fix assertion * Remove sampling method, it was not implemented in 8.19
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
) elastic#112645 introduced support for multi-value dimensions but downsampling was not handling that correctly. **Observed behaviour** Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field. **Fix** After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#112645 introduced support for multi-value dimensions but downsampling was not handling that correctly.
Observed behaviour
Downsampling will store only one value in the downsampled document, if a document has more than one values for a dimension field.
Fix
After this fix, downsampling will create an object array with all the values and store that in the downsampled document. We also added extra tests.