Make items public that are necessary to add custom prepasses in application code.#21962
Merged
Merged
Conversation
application code. Currently, custom prepasses can't be easily added outside the `bevy_pbr` crate for two reasons: 1. The fields in `PrepassSpecializer` are private to the `bevy_pbr` crate, so a `PrepassSpecializer` can't be constructed. Furthermore, the `PrepassSpecializer::specialize` method itself calls private APIs, so a developer can't even copy and paste the `PrepassSpecializer` into application code. 2. The `set_mesh_motion_vector_flags` system is private, meaning that specialization systems for custom prepasses can't be ordered after it. This is a problem because those specialization systems may need to read the motion vector flags that that system sets. This commit changes the fields in `PrepassSpecializer` to be public, and also changes the `set_mesh_motion_vector_flags` system to be public.
IceSentry
approved these changes
Nov 28, 2025
mockersf
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, custom prepasses can't be easily added outside the
bevy_pbrcrate for two reasons:The fields in
PrepassSpecializerare private to thebevy_pbrcrate, so aPrepassSpecializercan't be constructed. Furthermore, thePrepassSpecializer::specializemethod itself calls private APIs, so a developer can't even copy and paste thePrepassSpecializerinto application code.The
set_mesh_motion_vector_flagssystem is private, meaning that specialization systems for custom prepasses can't be ordered after it. This is a problem because those specialization systems may need to read the motion vector flags that that system sets.This commit changes the fields in
PrepassSpecializerto be public and also changes theset_mesh_motion_vector_flagssystem to be public.