chore: switch restore ops to cluster restore API#10246
Open
leon-ape wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## support/dp-backup-pvc-restore #10246 +/- ##
=================================================================
- Coverage 53.03% 52.65% -0.39%
=================================================================
Files 533 533
Lines 62596 62498 -98
=================================================================
- Hits 33200 32910 -290
- Misses 25998 26219 +221
+ Partials 3398 3369 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
44ab657 to
0120931
Compare
54abdc3 to
e01911c
Compare
0120931 to
3a0cd73
Compare
e01911c to
5b8cfb5
Compare
5b8cfb5 to
ded02d3
Compare
3a0cd73 to
404c845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch restore ops to the new Cluster restore API and remove the old annotation-based restore plumbing.
Changes
spec.restore.kubeblocks.io/restore-from-backup.Cluster.spec.restore.Not included
Validation
make generatemake manifestsmake docmake fmtmake lintKUBEBUILDER_ASSETS="/Users/leon/Library/Application Support/io.kubebuilder.envtest/k8s/1.26.1-darwin-arm64" go test ./pkg/operations -run TestAPIsKUBEBUILDER_ASSETS="/Users/leon/Library/Application Support/io.kubebuilder.envtest/k8s/1.26.1-darwin-arm64" go test ./pkg/controller/planKUBEBUILDER_ASSETS="/Users/leon/Library/Application Support/io.kubebuilder.envtest/k8s/1.26.1-darwin-arm64" go test ./controllers/dataprotection ./controllers/apps/cluster/... ./controllers/apps/component/...Diff audit
Compared with the original large branch, the stacked result only differs by generated InstanceSet CRD/API docs from
make manifests/doc, a test-only removal of a DP constant import frompkg/controllerutil/volume_util_test.go, and deletion of the unuseddataprotection.kubeblocks.io/volume-sourceparameter.