close
Skip to content

docs: remove Twitter and X references#157

Open
jasperdevs wants to merge 1 commit into
angular-hispano:mainfrom
jasperdevs:codex/remove-twitter-x-references
Open

docs: remove Twitter and X references#157
jasperdevs wants to merge 1 commit into
angular-hispano:mainfrom
jasperdevs:codex/remove-twitter-x-references

Conversation

@jasperdevs
Copy link
Copy Markdown

Closes #156.

Summary

  • Remove Angular Hispano X link from shared link constants, footer, and navigation social menu
  • Remove X/Twitter release-notification text from the update docs in Spanish and English

Verification

  • npm ci with Node 22.22.3
  • git diff --check
  • rg -n "x\.com|Twitter|twitter|ngLinks\.X|X \(formerly|antes Twitter|anteriormente Twitter|@angular en X|@angular on X" adev-es/src/app/core adev-es/src/content/best-practices/update*.md returned no matches

Note: I started npm run build, but stopped it after it spent ~20 minutes building the full upstream Angular/Bazel production target rather than this repo-specific docs surface.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution! We need a few minor tweaks to the code submitted.

Then we also need the CLA signed, and the commit signed (more on GitHub signed commits here).

Comment on lines -9 to -11
<li>
<a [href]="ngLinks.X" title="X (formerly Twitter)">X (formerly Twitter)</a>
</li>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .en files are the original English files before being translated. We don't need to keep them updated like this. They aren't used/rendered. They are just kept to reference changes so we know what might need re-translation.

</svg>
</a>
</li>
<li>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, we don't want to update these .en files.


## Getting notified of new releases

To be notified when new releases are available, follow [@angular](https://x.com/angular '@angular on X') on X (formerly Twitter) or subscribe to the [Angular blog](https://blog.angular.dev 'Angular blog').
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert.

@Splaktar
Copy link
Copy Markdown
Member

Please add the following to the commit message:


Fixes #156.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminar las referencias a Twitter/X

3 participants