Issue (P0 Bug)
#38206
Pull Request(s)
#38216
AMP Version(s)
2205051832000, 2204221712000, 2205051832000
Channels
Beta / Experimental, Stable, LTS
Formats
Stories
Justification
On video-heavy stories, the audio of later videos don't play if they have the noaudio attribute on earlier videos (through the Google video cache or manual addition of the attribute), and can throw a CORS error if the videos are crossorigin. There is no way to bring back the audio by muting/unmuting, because the video element from the mediapool is corrupted and can't play audio after that until the browser is refreshed. Bug introduced by #37712.
This affects stories in a significant way (videos can't be unmuted).
Verification Steps
Unmute the story https://www.thinkwithgoogle.com/consumer-insights/consumer-trends/trending-visual-stories/viewer-choice-reshapes-content on the first video with audio (page 6), the last video with audio (3rd from the last) should play the audio and not be muted.
Note: this only works if the story starts playing from the beginning, not if you open the story directly on the last page (in that case, the first video might be muted).
Summary
We used gain nodes that control volume (a not well tested integration) to implement a feature for a very used attribute (noaudio).
Impact
Users in all browsers and all viewers, for stories that have many videos where some are muted and some are not muted.
Action Items
No response
Notifications
/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers
Issue (P0 Bug)
#38206
Pull Request(s)
#38216
AMP Version(s)
2205051832000, 2204221712000, 2205051832000
Channels
Beta / Experimental, Stable, LTS
Formats
Stories
Justification
On video-heavy stories, the audio of later videos don't play if they have the
noaudioattribute on earlier videos (through the Google video cache or manual addition of the attribute), and can throw a CORS error if the videos are crossorigin. There is no way to bring back the audio by muting/unmuting, because the video element from the mediapool is corrupted and can't play audio after that until the browser is refreshed. Bug introduced by #37712.This affects stories in a significant way (videos can't be unmuted).
Verification Steps
Unmute the story https://www.thinkwithgoogle.com/consumer-insights/consumer-trends/trending-visual-stories/viewer-choice-reshapes-content on the first video with audio (page 6), the last video with audio (3rd from the last) should play the audio and not be muted.
Note: this only works if the story starts playing from the beginning, not if you open the story directly on the last page (in that case, the first video might be muted).
Summary
We used gain nodes that control volume (a not well tested integration) to implement a feature for a very used attribute (
noaudio).Impact
Users in all browsers and all viewers, for stories that have many videos where some are muted and some are not muted.
Action Items
No response
Notifications
/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers