Plugin Check: Missing $domain parameter

[masteradhoc]

Describe the bug

The Plugin Check Plugin shows different issues. One of it is the Missing $domain parameter message. See below the notes:

includes/function.login-footer.php

Line	Column	Type	Code	Message	Docs
29	21	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to _x().	Docs

includes/function.login-header.php

Line	Column	Type	Code	Message	Docs
53	29	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to __().	Docs
57	33	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to __().	Docs
104	25	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to __().	Docs
130	9	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to __().	Docs
133	57	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to __().	Docs

providers/class-two-factor-backup-codes.php

Line	Column	Type	Code	Message	Docs
179	27	ERROR	WordPress.WP.I18n.MissingArgDomain	Missing $domain parameter in function call to esc_html_e().	Docs

Steps to Reproduce

1. Install Plugin Check Plugin
2. Choose Two Factor, Categories = "General" and Types = "Error" & "Warning"
3. see results
4. apply fix
5. see results

Screenshots, screen recording, code snippet

No response

Environment information

No response

Please confirm that you have searched existing issues in this repository.

Yes

Please confirm that you have tested with all plugins deactivated except Two-Factor.

Yes

[kasparsd]

The files under includes directory are copies of WP core files with minor modifications because WP core doesn't any other way to filter/adjust that logic, see:

two-factor/class-two-factor-core.php

Lines 962 to 965 in 9348f6c

	if ( ! function_exists( 'login_header' ) ) {
	// We really should migrate login_header() out of `wp-login.php` so it can be called from an includes file.
	require_once TWO_FACTOR_DIR . 'includes/function.login-header.php';
	}

The other providers/class-two-factor-backup-codes.php is totally valid -- we should definitely add the textdomain for those strings.