Fix meta description no-provider modal#558
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #558 +/- ##
==========================================
Coverage 71.21% 71.21%
Complexity 1151 1151
==========================================
Files 67 67
Lines 5565 5565
==========================================
Hits 3963 3963
Misses 1602 1602
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What?
Prevents the Meta Description modal from opening when no AI provider is configured.
Why?
When clicking Generate Meta Description without a configured AI Connector, the plugin correctly shows the provider warning. However, the Meta Description modal also opened even though generation could not proceed.
This made the UI feel inconsistent with the other no-provider flows, where the user only sees the provider notice and is directed to configure a connector.
How?
Manage Connectorsaction.Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT / Codex
Used for: Repository review, implementation guidance, test updates, and local verification. I reviewed the changes, tested the behavior locally, and take responsibility for the final submission.
Testing Instructions
Automated checks run locally:
npm run lint:js -- src/experiments/meta-description/components/useMetaDescription.ts src/experiments/meta-description/components/MetaDescriptionPanel.tsx tests/e2e/specs/experiments/no-provider-degradation.spec.jsnpm run typechecknpm run test:e2e -- tests/e2e/specs/experiments/no-provider-degradation.spec.jsScreenshots or screencast
Before
No provider is configured. The warning appears, but the Meta Description modal also opens even though generation cannot proceed.
After
No provider is configured. The same warning appears, but the Meta Description modal stays closed.