close
Skip to content

Added comment box option when creating a new area/point/polygon#134

Merged
seveibar merged 6 commits into
UniversalDataTool:masterfrom
erobaina:master
Feb 12, 2021
Merged

Added comment box option when creating a new area/point/polygon#134
seveibar merged 6 commits into
UniversalDataTool:masterfrom
erobaina:master

Conversation

@erobaina
Copy link
Copy Markdown

@erobaina erobaina commented Jan 28, 2021 •
edited
Loading

Description

Added the ability to pass a prop that will determine whether to show a comment box or not.
After you hit the Save button, the comment will be part of that region object.

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Jan 29, 2021

hey @erobaina thanks for the PR :) it looks pretty good but I'm going to run a test manually. We don't use the package-lock.json file (we use yarn.lock), can you remove that file?

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Jan 29, 2021

nvm it turns out i can :)

seveibar
seveibar reviewed Jan 29, 2021
View reviewed changes
Comment thread src/RegionLabel/index.js
import React, { useRef, memo } from "react"
import Paper from "@material-ui/core/Paper"
import { makeStyles } from "@material-ui/core/styles"
import styles from "./styles"
Copy link
Copy Markdown
Contributor

@seveibar seveibar Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to import TextField (it doesn't compile?)

Copy link
Copy Markdown
Author

@erobaina erobaina Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seveibar
That's right, sorry I missed that

seveibar
seveibar requested changes Jan 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't compile 😢

@erobaina
Copy link
Copy Markdown
Author

erobaina commented Jan 29, 2021

doesn't compile 😢

Just pushed a new commit with the import, good catch! Thank you

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Jan 29, 2021

See how you have a merge commit? You can avoid that and keep a cleaner git history by doing git pull --rebase, then it'll apply your changes on top of the existing stuff :)

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Jan 29, 2021

Hmm where's the comment box?
image

@erobaina
Copy link
Copy Markdown
Author

erobaina commented Jan 29, 2021

Hmm where's the comment box?
image
@seveibar
Sorry about that, I missed passing one prop, now it should work

Screen Shot 2021-01-29 at 15 50 36

@erobaina erobaina requested a review from seveibar February 3, 2021 14:41
@seveibar seveibar merged commit 03e0734 into UniversalDataTool:master Feb 12, 2021
seveibar pushed a commit that referenced this pull request Feb 12, 2021
@semantic-release-bot
chore(release): 1.8.0 [skip ci]
a0008b0 
# [1.8.0](v1.7.12...v1.8.0) (2021-02-12)

### Bug Fixes

* Merge pull request [#134](#134) from erobaina/master ([03e0734](03e0734))

### Features

* Merge pull request [#135](#135) from sreevardhanreddi/master ([5e05674](5e05674))
@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Feb 12, 2021

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seveibar seveibar seveibar approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erobaina @seveibar @emi-castellano