close
Skip to content

Change default deletion shortcut to D#111

Merged
seveibar merged 1 commit into
UniversalDataTool:masterfrom
Hummer12007:fix-del
Nov 23, 2020
Merged

Change default deletion shortcut to D#111
seveibar merged 1 commit into
UniversalDataTool:masterfrom
Hummer12007:fix-del

Conversation

@Hummer12007
Copy link
Copy Markdown
Contributor

@Hummer12007 Hummer12007 commented Nov 23, 2020

react-hotkey breaks when using Delete

@Hummer12007
Change default deletion shortcut to D
06a4d02 
react-hotkey breaks when using Delete
@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Nov 23, 2020

Makes sense to me!

@seveibar seveibar merged commit ee87f6c into UniversalDataTool:master Nov 23, 2020
seveibar pushed a commit that referenced this pull request Nov 23, 2020
@semantic-release-bot
chore(release): 1.7.5 [skip ci]
3b5a554 
## [1.7.5](v1.7.4...v1.7.5) (2020-11-23)

### Bug Fixes

* Merge pull request [#111](#111) from Hummer12007/fix-del ([ee87f6c](ee87f6c))
* Merge pull request [#112](#112) from Hummer12007/undo-shortcut ([e2aaa86](e2aaa86))
@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Nov 23, 2020

🎉 This PR is included in version 1.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Ownmarc
Copy link
Copy Markdown

Ownmarc commented Nov 23, 2020 •
edited
Loading

Isn't this a lazy fix ? I think we should try to find what the bug is with the delete key and see if we can fix it. We could go with a solution like this if there is no way to reliably support the delete key.

@Hummer12007
Copy link
Copy Markdown
Contributor Author

Hummer12007 commented Nov 23, 2020 •
edited
Loading

I think it is an upstream react-hotkeys issue. I didn't manage to figure it out within an hour though.
react-hotkeys has a fair share of issues on its own (and it's not realy maintained), so it would probably be wiser to migrate to something else in the long run.

The (~actual) issue from the first glance seems to be that pressing Delete breaks react-hotkeys until you refocus the window (even when it is not bound to anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hummer12007 @seveibar @Ownmarc