Add use http body params flag to requester#9
Merged
Conversation
javiromero
reviewed
Jul 8, 2021
skqr
reviewed
Jul 8, 2021
| data = self._transport_details_non_partnered(shipment_type, data, **kwargs) | ||
|
|
||
| return self.make_request(data, method="POST") | ||
| return self.make_request(data, method="POST", use_body_params=True) |
There was a problem hiding this comment.
Just to double check - this would make it so that we're only using the alternate behaviour when interacting with the MWS Inbound Shipments API, correct?
Author
There was a problem hiding this comment.
Yes exactly, and only that specific function from it (put_transport_content).
javiromero
approved these changes
Jul 9, 2021
javiromero
left a comment
There was a problem hiding this comment.
LGTM, do we need to bump the lib version https://github.com/Shiphero/python-amazon-mws/blob/develop/setup.py#L6 or is it automatic?
Author
@javiromero yeah i better do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.